Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

15.1.0 #583

Merged
merged 7 commits into from
Sep 9, 2021
Merged

15.1.0 #583

merged 7 commits into from
Sep 9, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 9, 2021

This is the release candidate for version 15.1.0.

github-actions and others added 2 commits September 9, 2021 15:06
@gantunesr gantunesr requested review from a team and jpuri and removed request for a team and jpuri September 9, 2021 15:30
@gantunesr gantunesr marked this pull request as ready for review September 9, 2021 15:31
@gantunesr gantunesr requested a review from a team as a code owner September 9, 2021 15:31
Gudahtt
Gudahtt requested changes Sep 9, 2021
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you include an entry for #581 as well? To indicate that immer was updated from v8 to v9. That PR was more than just a lockfile change - the dependency range changed as well.

adonesky1
adonesky1 reviewed Sep 9, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
Gudahtt
Gudahtt reviewed Sep 9, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
Gudahtt
Gudahtt previously approved these changes Sep 9, 2021
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

adonesky1
adonesky1 reviewed Sep 9, 2021
View reviewed changes
CHANGELOG.md Outdated
## [15.1.0]
### Changed
- Improve transaction state management ([#582](https://github.com/MetaMask/controllers/pull/582))
- Update on the TransactionController to reconcile the data between local and remote sources (Etherscan) and avoid misleading display of gas or status information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ❤️

adonesky1
adonesky1 previously approved these changes Sep 9, 2021
View reviewed changes
sethkfman
sethkfman approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr merged commit c7d7480 into main Sep 9, 2021
@gantunesr gantunesr deleted the release/15.1.0 branch September 9, 2021 15:56
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@github-actions @MajorLift
15.1.0 (#583)
3a7d2fc
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@github-actions @MajorLift
15.1.0 (#583)
efb8391
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adonesky1 adonesky1 adonesky1 approved these changes

@sethkfman sethkfman sethkfman approved these changes

@Gudahtt Gudahtt Gudahtt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gudahtt @sethkfman @adonesky1 @gantunesr